always render toolbar when in screen reader mode #183150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
May 22, 2023
roblourens
reviewed
May 22, 2023
roblourens
reviewed
May 22, 2023
| const toolbarElt = this.toolbar.getElement(); | ||
| if (this._accessibilityService.isScreenReaderOptimized()) { | ||
| toolbarElt.style.display = 'block'; | ||
| toolbarElt.ariaLabel = this._configurationService.getValue(AccessibilityVerbositySettingId.Chat) ? localize('chat.codeBlock.toolbarVerbose', 'Toolbar for code block which can be reached via tab') : localize('chat.codeBlock.toolbar', 'Code block toolbar'); |
There was a problem hiding this comment.
Need to reset the aria label too?
There was a problem hiding this comment.
That probably doesn't matter since they are not in screenreader mode
roblourens
approved these changes
May 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows screen reader users to discover and navigate the toolbar via keyboard
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4167